Solar Time

// Assumes solar noon always occurs at 12:00 PM
function optimizeSolarPanels(date, longitude) {
  const solarNoon = new Date(date);
  solarNoon.setHours(12, 0, 0, 0); // Wrong! Ignores equation of time
  
  // This can be off by up to 16 minutes
  return calculateOptimalAngle(solarNoon);
}

// Ignores the difference between solar and clock time
function calculateSunrise(date, latitude, longitude) {
  // Simplified calculation that ignores equation of time
  const dayOfYear = getDayOfYear(date);
  const solarDeclination = calculateDeclination(dayOfYear);
  
  // This calculation is missing the equation of time correction
  const hourAngle = Math.acos(-Math.tan(latitude) * Math.tan(solarDeclination));
  return 12 - (hourAngle * 12 / Math.PI); // Inaccurate!
}

// Assumes sundial time matches clock time
function validateSundialApp(clockTime, sundialReading) {
  // This will fail because sundials show apparent solar time
  // which differs from clock time by up to 16 minutes
  return Math.abs(clockTime - sundialReading) < 60000; // 1 minute tolerance
}

// Properly calculate solar noon using equation of time
function calculateSolarNoon(date, longitude) {
  const dayOfYear = getDayOfYear(date);
  const equationOfTime = calculateEquationOfTime(dayOfYear);
  
  // Convert longitude to time offset (4 minutes per degree)
  const longitudeOffset = longitude * 4; // minutes
  
  // Solar noon = 12:00 + longitude offset + equation of time
  const solarNoonMinutes = 12 * 60 + longitudeOffset + equationOfTime;
  
  const solarNoon = new Date(date);
  solarNoon.setHours(0, solarNoonMinutes, 0, 0);
  
  return solarNoon;
}

// Calculate equation of time (simplified approximation)
function calculateEquationOfTime(dayOfYear) {
  const B = (360 / 365) * (dayOfYear - 81) * (Math.PI / 180);
  
  // Simplified equation of time in minutes
  const equationOfTime = 9.87 * Math.sin(2 * B) - 7.53 * Math.cos(B) - 1.5 * Math.sin(B);
  
  return equationOfTime;
}

// Accurate sunrise calculation with equation of time
function calculateAccurateSunrise(date, latitude, longitude) {
  const dayOfYear = getDayOfYear(date);
  const solarDeclination = calculateDeclination(dayOfYear);
  const equationOfTime = calculateEquationOfTime(dayOfYear);
  
  // Calculate hour angle for sunrise
  const hourAngle = Math.acos(-Math.tan(latitude * Math.PI / 180) * 
                             Math.tan(solarDeclination * Math.PI / 180));
  
  // Convert to time, accounting for longitude and equation of time
  const sunriseTime = 12 - (hourAngle * 12 / Math.PI) + 
                     (longitude / 15) + (equationOfTime / 60);
  
  const sunrise = new Date(date);
  sunrise.setHours(Math.floor(sunriseTime), (sunriseTime % 1) * 60, 0, 0);
  
  return sunrise;
}

// Proper sundial validation accounting for solar vs clock time
function validateSundialReading(clockTime, sundialReading, longitude) {
  const equationOfTime = calculateEquationOfTime(getDayOfYear(clockTime));
  const longitudeCorrection = longitude * 4; // 4 minutes per degree
  
  // Convert clock time to apparent solar time
  const apparentSolarTime = new Date(clockTime.getTime() + 
    (equationOfTime + longitudeCorrection) * 60000);
  
  // Now compare with sundial reading (which shows apparent solar time)
  const difference = Math.abs(apparentSolarTime.getTime() - sundialReading.getTime());
  
  return difference < 120000; // 2 minute tolerance for measurement error
}